brp improvements #12
brp improvements #12
Conversation
Ground work for vfork()+chroot() brp_realpath() Also removes access() check in read_filter, because brp_realpath() should have already made sure the file exists by using lstat()
Also, brp_realpath is replaced by brp_openplus brp_realpath returns a path, which in most case is not what the caller wanted. Causing them to repeat brp_realpath's work (e.g. lstat()). The new function returns a file descriptor and stat instead.
Prepare for chroot()
Now instead of resolving symlink relative to stratum root manually, we first chroot() into the stratum root, then let the kernel do the path resolution.
Reduce the number of seteuid() calls, which is quite heavy
|
@paradigm Is this useful for Poki? Should it be closed? Was this maybe addressed by the fork? |
|
All the development happens in github.com/bedrocklinux rather than my personal repo, and I check there for things like PRs. I completely missed this. I saw some of @yshui's other stuff and commented but then forgot about it as, again, I'm not in the habit of coming here. That's on me - I should have been watching this. It almost certainly notified me and I apparently just missed it. Not only do I feel bad for not having been responded in terms of just being professional, but also because this is obviously a non-trivial amount of work (I didn't want to write a C config parser because it was too much work, and @yshui did so here), and even more so because this is very, very good stuff. The other big change here, using I don't think we can use this as-is. Poki's equivalent has drifted too much; I did a clean re-write with some new ideas. I'm using I really, really hope I didn't discourage @yshui off from further contribution, as he/she was clearly ahead of me here and there's plenty of potential for further benefit. I'm greatly saddened I didn't watch github.com/paradigm more closely or that @yshui didn't reach out to any of the contact methods listed on the website that I do watch more actively. @yshui If you're still interested in contributing there's definitely stuff we could use your help with. Let me know and I can try to catch you to where the project is now and highlight some areas that could use your touch. If you've lost interest in Bedrock in the last couple years, I don't blame you in the slightest. @Mouvedia Thanks for bringing this to my attention. Wish you saw it two years ago. I'll leave this open until either @yshui responds otherwise or I get time to review this in detail and see if there's other things like |
Main contribution of this patch is:
Plus a couple of other changes.